Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow a float type as a substitution value in transactional templates #976

Merged
merged 6 commits into from
Jun 15, 2020
Merged

fix: allow a float type as a substitution value in transactional templates #976

merged 6 commits into from
Jun 15, 2020

Conversation

thinkingserious
Copy link
Contributor

Fixes #861

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 10, 2020
@childish-sambino childish-sambino changed the title fix: allow a float type as a substitution value in transactional temp… fix: allow a float type as a substitution value in transactional templates Jun 11, 2020
childish-sambino
childish-sambino reviewed Jun 11, 2020
View reviewed changes
lib/mail/Substitution.php Outdated Show resolved Hide resolved
test/unit/SubstitutionTest.php Outdated Show resolved Hide resolved
test/unit/SubstitutionTest.php Outdated Show resolved Hide resolved
test/unit/SubstitutionTest.php Outdated Show resolved Hide resolved
test/unit/SubstitutionTest.php Outdated Show resolved Hide resolved
lib/mail/Substitution.php Outdated Show resolved Hide resolved
@thinkingserious thinkingserious merged commit 12a202d into master Jun 15, 2020
@thinkingserious thinkingserious deleted the is-numeric branch June 15, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Floats in macros
2 participants
@thinkingserious @childish-sambino